-
Notifications
You must be signed in to change notification settings - Fork 41.7k
Decorate all Assert implementations with @CheckReturnValue #46766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
72390fd to
8978e51
Compare
|
See #32683 (comment) |
|
As I need to extend Checkstyle's
or should I define a more fine-grained rule, restricting it to the following packages?
|
Yep. The intention is to restrict only to certain AssertJ entry point and this is one of them so I think that's ok. |
|
@scordio how is it going, anything I can do to help? |
|
Apologies, life happened and this fell off my radar! 🤦 If not in a rush, I'm happy to continue on it over the weekend. |
|
Thanks, @scordio. There's no rush. |
76f6b34 to
934b746
Compare
|
When building the project locally, I get two NullAway errors on but the CI seems fine 🤔 |
|
@scordio you need Java 24 to build the project |
This comment was marked as outdated.
This comment was marked as outdated.
934b746 to
df47244
Compare
buildSrc/src/main/java/org/springframework/boot/build/architecture/ArchitectureRules.java
Outdated
Show resolved
Hide resolved
df47244 to
d045ca2
Compare
|
I've moved to this to 4.x as we're approaching RC1 but not worries either way. Thanks for your efforts! |
d045ca2 to
802b3db
Compare
c744ebb to
17cb2f0
Compare
0b2f0e8 to
bbb9c1c
Compare
wilkinsona
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much, @scordio.
I've left a couple of very minor comments. No need for you to do anything about them unless you really want to. We can take care of them when we merge this. That'll take a little while as it'll hopefully go in Spring Boot 4.1 and we need to first get 4.0 out of the door and then create the 4.0.x maintenance branch.
...sts/src/systemTest/java/org/springframework/boot/image/assertions/ContainerConfigAssert.java
Outdated
Show resolved
Hide resolved
...sts/src/systemTest/java/org/springframework/boot/image/assertions/ContainerConfigAssert.java
Outdated
Show resolved
Hide resolved
|
Thanks, @wilkinsona! I'll address them later in the day. |
Signed-off-by: Stefano Cordio <[email protected]>
bbb9c1c to
18513ed
Compare
See #32683.
Deliverables
Assertimplementations